Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #266 correctly restore terminal parameters #17

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

joeycumines
Copy link

@joeycumines joeycumines commented Aug 13, 2023

I originally created this PR to address c-bata#266, but it looks like this fork already had a fix, which was for c-bata#228.

There was an additional bug, however - the file descriptor was being closed prior to restoring the terminal parameters. I assume that meant that the restore itself did nothing.

This also fixes a nearby code error that's unlikely to cause any actual issues.
I also addressed a staticcheck lint issue.

@Verseth Verseth merged commit 1ccfc35 into elk-language:master Aug 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants